feat: ObjectsMatch and JsonContentsMatch (unordered nested slices)#1928
Open
sonnemusk wants to merge 6 commits into
Open
feat: ObjectsMatch and JsonContentsMatch (unordered nested slices)#1928sonnemusk wants to merge 6 commits into
sonnemusk wants to merge 6 commits into
Conversation
Deep equality that treats slices/arrays as unordered multisets at every level (structs and maps recurse). JsonContentsMatch applies the same rule to decoded JSON. Addresses stretchr#806.
Place forward/require wrappers alphabetically so .ci.gogenerate.sh diff check can pass (codegen panics on local Go 1.23).
Use space after // in doc examples so .ci.gogenerate.sh is clean.
Reset generated files and re-run codegen so ObjectsMatch and JsonContentsMatch wrappers match .ci.gogenerate.sh exactly.
Keep upstream generated files intact and only append ObjectsMatch / JsonContentsMatch wrappers so gofmt and go generate stay stable on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds deep equality helpers that treat every slice/array as an unordered multiset (like
ElementsMatch, but recursive into structs and maps). Addresses #806 and the JSON follow-up discussed on that issue.Details
[]bytecompared as ordered bytes (not as a bag of bytes)assert.Assertions,require, and*fformat variantsFixes #806