feat: Comparer interface for custom Equal assertions#1929
Open
sonnemusk wants to merge 1 commit into
Open
Conversation
Types may implement assert.Comparer so Equal/NotEqual use custom equality instead of reflect.DeepEqual. Useful for money/decimal types where different internal representations are equal in domain terms (issue stretchr#1204).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
assert.Comparerso domain types can define equality forEqual/NotEqual(and anything else usingObjectsAreEqual) withoutreflect.DeepEqualfield-by-field noise (issue #1204).Behavior
Comparer, useexpected.Equal(actual)Comparer, useactual.Equal(expected)[]byte/reflect.DeepEqualpathNo codegen changes; only
ObjectsAreEqualgrows a short interface check.Fixes #1204