Lift Starlight's .main-pane isolation on pages with hero art#197
Closed
kylemclaren wants to merge 1 commit into
Closed
Lift Starlight's .main-pane isolation on pages with hero art#197kylemclaren wants to merge 1 commit into
kylemclaren wants to merge 1 commit into
Conversation
Starlight sets isolation: isolate on .main-pane, which gives any mix-blend-mode element inside the content pane a transparent backdrop: the body background and the fixed dark-mode #sprites-bg art paint outside the isolated group, so blending silently no-ops and hero images render as flat black/white rectangles instead of merging into the page. Lift the isolation only on pages containing .hero-art (via :has), so every other page keeps Starlight's default stacking behavior. No-op until a page ships .hero-art images (see #193). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Preview Deployment
Commit: |
Contributor
Lighthouse Results
|
Contributor
E2E Test Results✅ Tests success Ran against: https://pr-197-superfly-sprites-docs.fly.dev |
kylemclaren
added a commit
that referenced
this pull request
Jul 2, 2026
A proper alpha export makes the blend-mode approach unnecessary: one image floats on any backdrop in both themes, so the dark/light variants, the dark-only/light-only utility, and the hero-art blend rules all go. Also makes the .main-pane isolation lift (#197) moot. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Starlight sets
isolation: isolateon.main-pane, which seals the content pane into its own stacking context. Anymix-blend-modeelement inside it blends against the isolated group's backdrop — which is fully transparent, because the page background (the<body>color, and in dark mode the fixed#sprites-bgblack + green-glow art fromBackground.astro) paints outside the group. The blend silently no-ops.This matters for hero art: the Managed Agents guide (#193) ships theme-conditional hero images whose flat black/white backgrounds are meant to be erased into the page via
screen/multiply. Without this change those images render as hard-edged rectangles.What
Scoped via
:has(.hero-art)so only pages that actually ship blend-mode hero art opt out of Starlight's default stacking; everything else (e.g. pages relying on contained z-indexes, like the lifecycle diagram) is untouched.Safety
.hero-artimages — merge order with Add Claude Managed Agents integration guide #193 doesn't matter.z-index: 2, contained by its ownposition: relativeframe) — nothing that can escape above the navbar.🤖 Generated with Claude Code