Workflow conditional + macOS - #94
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=============================================
Coverage 98.55623% 98.55623%
=============================================
Files 11 11
Lines 1316 1316
=============================================
Hits 1297 1297
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Prevent PR tagging job from running on forked repositories.
This workflow runs the Calkit pipeline on push and pull request events, handling Git operations and DVC integration.
Comment out the pull with retries step and enable DVC pulling.
…nFLASH into workflow-macos
Update to allow running TeX/matplotlib Docker env on arm64
There was a problem hiding this comment.
don't merge this since no longer necessary
There was a problem hiding this comment.
duplicate file? should be deleted anyway
| - pubs/JFM/figs/A_sparsity_plot.pdf | ||
| - pubs/JFM/figs/B_sparsity_plot.pdf | ||
| - pubs/JFM/figs/C_sparsity_plot.pdf | ||
| test-latex: |
There was a problem hiding this comment.
remove before merge
There was a problem hiding this comment.
remove before merge
| dependencies: | ||
| - sea-lab::open-flash>=v1.0.25 | ||
| - capytaine | ||
| - pip: |
There was a problem hiding this comment.
it's less ideal to install with pip in case i want to change packages later.
Can this be conditional so only on macosx it uses pip?
| - capytaine | ||
| - seaborn | ||
| # Compiler toolchain so pip can build capytaine's Fortran extension from | ||
| # source (no prebuilt arm64 wheel exists). Sets CC/FC during env activation. |
There was a problem hiding this comment.
I thought that the point of having calkit run everything in a docker container is to avoid os-specific setup. Since the docker container acts as linux no matter the machine, why do we need to bother with mac versions of packages?
There was a problem hiding this comment.
@petebachant see above question I had about your earlier PR that compiles Capytaine on macos
| fi | ||
|
|
||
| set +e # Continue even if pull fails | ||
| git pull --recurse-submodules |
There was a problem hiding this comment.
I think there is some recent logic added to this portion of the code in mdocean, check and update if so
2 participants
No description provided.