chore: release 2.3.1#1049
Open
piotr-iohk wants to merge 7 commits into
Open
Conversation
fix: use core LNURL-pay validation
Co-authored-by: Cursor <cursoragent@cursor.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
ovitrif
requested changes
Jun 26, 2026
Comment on lines
6
to
12
| @Suppress("TooGenericExceptionCaught") | ||
| suspend inline fun <R> runSuspendCatching(block: () -> R): Result<R> = | ||
| try { | ||
| Result.success(block()) | ||
| } catch (c: CancellationException) { | ||
| throw c | ||
| } catch (e: Throwable) { | ||
| Result.failure(e) | ||
| } | ||
| suspend inline fun <T> runSuspendCatching(crossinline block: suspend () -> T): Result<T> = try { | ||
| Result.success(block()) | ||
| } catch (error: Throwable) { | ||
| Result.failure(error) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
nit: needs to be patched/replaced with existing implementation of runSuspendCatching from master.
Can be done before merge to master, as merging hygiene step, no need to impact the actual patch release.
ovitrif
requested changes
Jun 26, 2026
ovitrif
left a comment
ovitrif
left a comment
Collaborator
There was a problem hiding this comment.
Added another nit, again, no changes for 2.3.1, this is only merge hygiene to cover all conflicts reported.
| barcode-scanning = { module = "com.google.mlkit:barcode-scanning", version = "17.3.0" } | ||
| biometric = { module = "androidx.biometric:biometric", version = "1.4.0-alpha05" } | ||
| bitkit-core = { module = "com.synonym:bitkit-core-android", version = "0.1.73" } | ||
| bitkit-core = { module = "com.synonym:bitkit-core-android", version = "0.1.74" } |
Collaborator
There was a problem hiding this comment.
nit: needs rebuilding bitkit-core on latest main there after the 0.1.74 changes merged with HEAD, version bump and bindings regen'ed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix release 2.3.1 (build 183) on top of v2.3.0.
Description
LnurlPayDatavalidationversionCode: 182 → 184versionName: 2.3.0 → 2.3.1Release
ovi/release-2.3.0Preview
N/A
QA Notes
@lnurl_1green with matching e2e branch (fix/lnurl-pay@d00494d)LightningRepoTestMade with Cursor