You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Only small items that popped up were the following:
1. Dead code from a checked-in reversal
Commit 1 added a LUD-06 description-hash / metadata check; commit 2 removed it. The result is:
validate_lnurl_pay_invoice's _metadata parameter is now unused, and data.metadata_str is passed through for no reason.
The public LnurlError::MetadataMismatch variant is now dead API surface in the generated Swift, Kotlin, and Python bindings.
The renamed test ..._with_different_description now documents that metadata is intentionally not checked.
2. No HTTP timeout on the callback fetch
The callback uses reqwest::get, which creates a client with no request timeout and follows redirects. A malicious or slow callback server can therefore keep the spawned task hanging indefinitely (e.g. via a Slowloris-style response).
Thanks @coreyphillips, reason to keep API surface changes smallest was for temporary reasons to not invalidate too much of previous session's testing; more cleanup will follow on this PR before merging it back to master 🙏🏻
Then we can change apps too so they don't need handling of "dead code" like MetadataMismatch error types, and those can go through normal release procedure which allows time to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
bitkit-coreto0.1.75and updates generated bindings.Core release: https://github.com/synonymdev/bitkit-core/releases/tag/v0.1.75
Preview
N/A
QA Notes
Manual Tests
N/A
Automated Checks
cargo fmtcargo test modules::lnurl./build.sh allswift package compute-checksum bindings/ios/BitkitCore.xcframework.zipgit diff --checksha256:9e4c13246dee06e38491d4112029352b60032df54ac7ed885a64375186c6dc3bv0.1.75