Skipped panel: capture the whole Venice error, spin the Retrying button - #464
Merged
Conversation
The skip-reason cards cut the context-length 400 off mid-sentence
("...for a total of at least 1638"). The card renders the stored
string in full - the clipping happened at capture: the edge client
sliced completions error bodies to 200 chars when building the
VeniceError message. Widen that slice to 600 (completions only - the
other endpoints' errors never land in a user-facing card) and raise
both skip-reason columns' storage caps from 500 to 1000 so the wider
message survives the SQL truncation too. Existing rows were stored
already-clipped and cannot be recovered; every failure from now on
stores the complete error.
The in-flight Retry state also read as dead: a disabled button whose
label flipped to "Retrying..." with no motion. Prepend the wiki
fleet's AsciiSpinner (the bar spinner the librarian strip uses,
aria-hidden so the frame swaps stay out of screen-reader
announcements) so the button visibly works while the server-side
retry runs. Both spinner modules' preambles also named stale call
sites (the memory strip moved to SleepSpinner); refreshed while
adding this third consumer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYNOPSIS
Skipped-panel polish from validating #462: full error text on the cards, live spinner on the Retrying button.
PURPOSE
The skip-reason cards cut the context-length 400 off mid-sentence ("...for a total of at least 1638"), and the in-flight Retry state was a motionless disabled button that read as hung.
DESCRIPTION
The card renders the stored string in full - the clipping happened at capture: the edge client sliced completions error bodies to 200 chars when building the
VeniceErrormessage, and the SQL skip path capped storage at 500. Completions error bodies now capture 600 chars (other endpoints stay at 200 - their errors never land in a user-facing card) and both skip-reason columns (wiki_last_skip_reason,wiki_record_last_skip_reason) store up to 1000, sized so the wider message is never clipped twice.The Retry button now leads with the wiki fleet's
AsciiSpinner(the librarian strip's bar spinner) while a retry is in flight - covering both the local click and the reload-recovered server-claim state - wrappedaria-hiddenso the frame swaps stay out of screen-reader announcements; the "Retrying..." text is the accessible signal.Notes:
create or replaceon the two failure RPCs; the deploy's sync job applies it on merge.SleepSpinner); refreshed while adding this third consumer.Generated by Claude Code