fix: deprecate no_extract parameter with DeprecationWarning#1793
Open
jacalata wants to merge 1 commit into
Open
fix: deprecate no_extract parameter with DeprecationWarning#1793jacalata wants to merge 1 commit into
jacalata wants to merge 1 commit into
Conversation
…ract no_extract was silently accepted but never documented as removed. Now raises DeprecationWarning and maps to include_extract=False so existing callers get a clear migration path rather than a silent no-op. Fixes #1541 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no_extractwas silently removed at some point; callers got a hardTypeErrorwith no migration pathDeprecationWarningthat mapsno_extract=Truetoinclude_extract=Falseso existing code keeps working while users migrateinclude_extractin the API reference (previously undocumented)Fixes #1541
Test plan
test_download_no_extract_emits_deprecation_warning(workbooks)test_download_no_extract_emits_deprecation_warning(datasources)🤖 Generated with Claude Code