Skip to content

Enforce repository and read model boundaries - #10

Merged
PANiXiDA merged 1 commit into
developmentfrom
feature/architecture-tests
Jul 30, 2026
Merged

Enforce repository and read model boundaries#10
PANiXiDA merged 1 commit into
developmentfrom
feature/architecture-tests

Conversation

@PANiXiDA

Copy link
Copy Markdown
Contributor

Что сделано

  • обновлён PANiXiDA.Core.Application до 2.0.5 из Add read model abstraction panixida-dotnet-core/application#4;
  • все 11 прикладных read-моделей теперь наследуются от ReadModel;
  • IRepository<,> ограничен aggregate roots, value objects, enumerations и strongly typed IDs без примитивов в предметных параметрах и результатах;
  • IReadRepository<> использует примитивный ID, не принимает Domain-типы и возвращает ReadModel из дополнительных методов;
  • добавлены соглашения об именовании/наследовании ReadModel и результате IQueryHandler<,>;
  • русский README синхронизирован со всеми 82 архитектурными тестами.

Проверки

  • dotnet build PANiXiDA.TacticalHeroes.slnx --no-restore — успешно;
  • unit tests — 176/176;
  • architecture tests — 82/82;
  • dotnet format ... --verify-no-changes — успешно;
  • каталог README: 82/82, последовательная нумерация, пропусков нет.

Полный Docker-зависимый прогон локально не завершился из-за внешнего EOF от registry-1.docker.io при загрузке axllent/mailpit:v1.30.4; изменение кода и архитектурные проверки собраны и пройдены отдельно.

@PANiXiDA
PANiXiDA marked this pull request as ready for review July 30, 2026 12:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9bc05f62ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +20 to +22
.Where(type => !type.Name.EndsWith(
ReadModelSuffix,
StringComparison.Ordinal))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Strip generic arity before checking the read-model suffix

When an Application assembly declares a valid generic model such as PagedReadModel<T> : ReadModel, reflection reports its name as PagedReadModel1, so this check incorrectly fails even though the source-level name ends with ReadModel. The inverse convention has the same normalization gap and therefore would not detect a generic PagedReadModel` that omits the base type; compare the existing repository-name checks, which explicitly remove generic arity before evaluating names.

Useful? React with 👍 / 👎.

@PANiXiDA
PANiXiDA merged commit 12a115c into development Jul 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants