fix: encode special characters in HTMLElement textContent setter#312
Open
spokodev wants to merge 1 commit into
Open
fix: encode special characters in HTMLElement textContent setter#312spokodev wants to merge 1 commit into
spokodev wants to merge 1 commit into
Conversation
The HTMLElement textContent setter stored the raw string in a TextNode without escaping, so setting textContent to a value containing '<', '>' or '&' produced markup that was re-interpreted as HTML on serialization and re-parsing (e.g. textContent = '<script>...' yielded a real <script> child). The base Node textContent setter already encodes via entities; this aligns HTMLElement with that behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HTMLElement.textContentsetter stored the raw string in a text node without escaping, so special characters were re-interpreted as markup:The base
Node.textContentsetter already encodes the value (cb11eab); theHTMLElementoverride was missed. Encode the value before storing it.