fix: stop appending a stray '<' to unterminated block-text elements#313
Open
spokodev wants to merge 1 commit into
Open
fix: stop appending a stray '<' to unterminated block-text elements#313spokodev wants to merge 1 commit into
spokodev wants to merge 1 commit into
Conversation
When a block-text element (script, style, pre, ...) has no closing tag, the text-end position fell back to dataEndPos, which subtracted the length of the *opening* frame-flag wrapper (frameflag.length + 2) rather than the *closing* one (frameflag.length + 3). The resulting off-by-one included the leading '<' of the internal </documentfragmentcontainer> sentinel, so parsing '<script>var a = 1;' produced text 'var a = 1;<'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unterminated raw-text element (
script/style/pre) with no closing tag keeps a stray<in its text:dataEndPoswas computed from the opening wrapper length, but the closing sentinel is one character longer, so the<of the sentinel was included when the element has no closing tag. Off by one in the EOF branch.