Optimize getFormattedTime method with snprintf#87
Merged
Conversation
Refactor time formatting to use snprintf for efficiency and avoid heap fragmentation.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors NTPClientPlus::getFormattedTime() to format hh:mm:ss using a fixed-size stack buffer and snprintf, reducing intermediate String allocations (and therefore reducing heap churn) while keeping the output identical.
Changes:
- Replaced per-component
Stringcreation + concatenation withsnprintfinto achar[9]buffer. - Constructed the final
Stringonce from the formatted buffer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor time formatting to use snprintf for efficiency and avoid heap fragmentation.
The original builds 4 separate String objects (hoursStr, minuteStr, secondStr + the final concatenation), my version builds only a single String at the very end – everything else happens in the fixed char buffer on the stack, with no heap allocations. Output format (e.g. "09:05:03") is identical. no need to change anything in ntp_client_plus.h