Fix udplogger header/implementation signature mismatch and refactor logString#90
Closed
techniccontroller with Copilot wants to merge 3 commits into
Closed
Fix udplogger header/implementation signature mismatch and refactor logString#90techniccontroller with Copilot wants to merge 3 commits into
techniccontroller with Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code comments by translating to German
Fix udplogger header/implementation signature mismatch and refactor logString
Jul 11, 2026
Owner
|
@copilot Comments in the code should be in english |
Author
Done — comments are now in English (commit |
techniccontroller
approved these changes
Jul 11, 2026
Owner
|
Close as contributor commits are missing in history, instead integration and fix is done in PR #91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
udplogger.hdeclaredlogString(String)while the implementation usedlogString(const String&), causing a compile/link failure. This PR aligns both and applies the underlying refactor.Changes
udplogger.h: UpdatedlogStringdeclaration toconst String& logmessageto match the implementationudplogger.cpp:logStringto takeconst String&— avoids an unnecessary copy on every calltoCharArraywithsnprintfinto the existing_packetBuffer— eliminates intermediate heap allocations triggered on every NTP sync (every 30s)