Add execution_time to activity execution info#807
Merged
Conversation
dandavison
reviewed
Jun 30, 2026
|
|
||
| // The time at which the activity is requested to start, computed as `schedule_time + start_delay`. | ||
| // Same as `schedule_time` if `start_delay` is not set. | ||
| google.protobuf.Timestamp requested_start_time = 38; |
Contributor
There was a problem hiding this comment.
I believe this has the same semantics as execution_time in workflow. Have we discussed whether to give them the same name?
Contributor
Author
There was a problem hiding this comment.
renamed to execution_time. Also actual_start_time is dropped, as discussed
fretz12
force-pushed
the
fredtzeng/saa-update-opts-start-delay
branch
from
95d0524 to
81a31ea
Compare
fretz12
force-pushed
the
fredtzeng/saa-start-delay-desc-list
branch
from
1f544ec to
5d01c86
Compare
fretz12
changed the title
maciejdudko
approved these changes
Jul 1, 2026
dandavison
approved these changes
Jul 1, 2026
fretz12
force-pushed
the
fredtzeng/saa-start-delay-desc-list
branch
from
3738191 to
390d4af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added execution_time to ActivityExecutionInfo (returned by DescribeActivityExecution — the time the activity is requested to start, computed as schedule_time + start_delay. Reflects the latest start_delay value if it was updated via UpdateActivityOptions.
Why?
Exposing execution_time makes the desired fire time directly observable in Describe.