Conversation
| /** | ||
| * Description of the workflow that backs a Nexus operation. | ||
| */ | ||
| final class WorkflowHandle |
There was a problem hiding this comment.
I was a little confused by the naming here as it felt a bit like this was a reference to a running workflow, but it's actually the input to a start workflow call.
Collaborator
Author
There was a problem hiding this comment.
This mirrors java's io.temporal.nexus.WorkflowHandle naming
If you think that we should rename it, please suggest alternatives
…n timeouts Address PR #768 review: - deadlineFromHeaders parses Request-Timeout only (operation timeout is the total budget, left in forwarded headers); applied to cancel context too - add scheduleToStart and startToClose timeouts to NexusOperationOptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Samples: temporalio/samples-php#75
Why?
Checklist
Closes
How was this tested: