Skip to content

make scoped logger work with logger objects with non-int level #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HoneyryderChuck wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

make scoped logger work with logger objects with non-int level #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions temporalio/lib/temporalio/scoped_logger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,21 @@ def add(severity, message = nil, progname = nil)
end
alias log add

# returns the logger log level as an integer.
def level
lvl = super

return lvl if lvl.is_a?(Integer)

return Logger::UNKNOWN unless lvl.respond_to?(:upcase)

if Logger::Severity.const_defined?(lvl.upcase, false)
Logger::Severity.const_get(lvl.upcase, false)
else
Logger::UNKNOWN
end
end

# @see Logger.debug
def debug(progname = nil, &)
add(Logger::DEBUG, nil, progname, &)
Expand Down