Fix anonymous block parameter in Workflow::Future RBI#494
Draft
fivetran-ryanrapp wants to merge 1 commit into
Draft
Fix anonymous block parameter in Workflow::Future RBI#494fivetran-ryanrapp wants to merge 1 commit into
fivetran-ryanrapp wants to merge 1 commit into
Conversation
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
In
rbi/temporalio/workflow/future.rbi, renamed the anonymous block parameter from&to&blockon line 16 ofTemporalio::Workflow::Future#initialize:Why?
The
sigdeclares a parameter namedblock:, but the method definition used&(anonymous block forwarding). Sorbet requires the parameter name in the sig to match the name in the method definition. With the anonymous form, Sorbet raises two errors (5003):The actual Ruby source at
lib/temporalio/workflow/future.rbalready uses&block— the RBI was inconsistent with the implementation.This also fixes a secondary issue for users of [tapioca](https://github.com/Shopify/tapioca): when tapioca generates a merged gem RBI by combining runtime reflection (which produces
&block) with this bundled RBI (which had&), the name mismatch caused therbigem to emit&&block— a parse error — in versions before 0.3.10. Consistent naming eliminates the mismatch regardless ofrbigem version.Checklist
Closes N/A — this is a one-line RBI correction with no associated issue
How was this tested:
srb tcno longer raises errors 5003 ("Malformed sig" / "Unknown parameter name") against this class after the changeAny docs updates needed? No