fix: honor --incognito by disabling the experience tracker (plan 009)#83
Closed
DavertMik wants to merge 1 commit into
Closed
fix: honor --incognito by disabling the experience tracker (plan 009)#83DavertMik wants to merge 1 commit into
DavertMik wants to merge 1 commit into
Conversation
`explorbot --incognito` ("Run without recording experiences") flowed CLI ->
ExplorBot -> Explorer, and Explorer called `new StateManager({ incognito })` —
but StateManager's constructor took no parameters, so the flag was silently
dropped and the ExperienceTracker was always enabled. Incognito runs read and
wrote ./experience like normal runs.
Thread `incognito` into the StateManager constructor and pass
`{ disabled: options.incognito }` to ExperienceTracker (which already supports
`disabled`). Argumentless constructions keep today's enabled behavior via
`options.disabled ?? false`.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Closing per request — the incognito fix isn't wanted. Reopen if that changes. |
Explorbot Self-RegressionCommit
Attempt details
Session analysis — basic (native): Session AnalysisThe Issues list page was explored across 5 test scenarios covering navigation to new issue creation, filtering by labels, searching issues, filtering by status, and navigating to issue details. All core flows completed successfully from a product standpoint, though some automation execution issues occurred during test execution. Coverage
What works
Execution Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements plan 009 (
plans/009-*.md) as a standalone PR offmain.explorbot --incognito("run without recording experiences") flowed CLI → ExplorBot → Explorer, and Explorer callednew StateManager({ incognito })— butStateManager's constructor took no parameters, so the flag was silently dropped and theExperienceTrackerstayed enabled. Incognito runs read and wrote./experiencelike normal runs.Fix
Thread
incognitointo theStateManagerconstructor and pass{ disabled: options.incognito }toExperienceTracker(which already supportsdisabled). Argument-less constructions keep today's enabled behavior viaoptions.disabled ?? false.Verification
bun test tests/unit→ 757 pass, 0 fail (incl. 2 new incognito tests);bunx tsc --noEmit→ 723.Note
This is the clean re-do of the mistakenly-stacked #78. It touches only the
StateManagerconstructor signature + theExperienceTrackerline; plan 010 (#separate PR) touches the same constructor to addknowledgeTracker, so whichever of the two merges second needs a one-line constructor merge ({ incognito?, knowledgeTracker? }). Both are independently valid offmain.🤖 Generated with Claude Code