feat: SW-2292 dark-mode styling polish (palette + selected/hover contrast)#179
Open
boramyi-ts wants to merge 3 commits into
Open
feat: SW-2292 dark-mode styling polish (palette + selected/hover contrast)#179boramyi-ts wants to merge 3 commits into
boramyi-ts wants to merge 3 commits into
Conversation
…A2670)
Brighten the dark-mode --primary to a clearer sky-blue and deepen --secondary
to a navy container, per the dark-mode styling review. Values are the OKLCH
equivalents of the approved hex colors; foreground pairings are unchanged and
retain AA contrast (dark #102F72 on the light primary; light #DADEFD on the
navy secondary).
Verified via the postbuild Tailwind compile that the shipped CSS emits
`.bg-primary { background-color: var(--primary) }` / `.bg-secondary {
background-color: var(--secondary) }` and the compiled `.dark {}` block carries
the new token values.
Tabs/ToggleGroup selected-state polish intentionally deferred — main already
diverged from the prototype baseline (bg-card / bg-accent) and needs a design
decision.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Port the contrast bumps validated in the visual-audit prototype into the kit components (0.7.0 stock was too low-contrast in dark mode): - ToggleGroup selected item -> primary fill (both modes), scoped to group items via twMerge so standalone Toggle keeps its subtle bg-accent on-state. - Tabs active (default variant, dark) -> lift the chip to color-mix(--card, white 20%) so it clearly separates from the track. - Ghost + Outline button hover -> full accent in dark (drop the faint dark:hover:bg-accent/50 and dark:hover:bg-input/50); outline matches ghost. - Secondary + Default button hover -> shift the fill 15% toward its OWN foreground token (a visible darken/lighten in both modes) instead of the stock opacity reduction; default matches secondary. Verified: lint, typecheck, test:all; postbuild Tailwind compile emits the color-mix utilities correctly; twMerge drops the inherited bg-accent for ToggleGroup items only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
boramyi-ts
temporarily deployed
to
artifactory-prod
July 15, 2026 16:58 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
boramyi-ts
enabled auto-merge (squash)
July 15, 2026 17:06
…ght mode) In light mode --info already equals --primary (#2F45B5); in dark they had diverged (#B9C7FF vs #B2D3FF). Set dark --info to the primary value so info mirrors primary in both themes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
boramyi-ts
temporarily deployed
to
artifactory-prod
July 15, 2026 18:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
owilliams-tetrascience
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dark-mode styling polish for the v1.0.0 GA kit (SW-2292): a brighter dark palette plus higher-contrast selected and hover states. Stock 0.7.0 renders several of these too faintly in dark mode.
Changes
Palette tokens (
src/index.tailwind.css, dark.dark {}):--primary→#B2D3FF(oklch(0.8578 0.071 255.72)), a clearer sky-blue--secondary→#1A2670(oklch(0.3119 0.1277 270.01)), a deeper navy container--info(dark) → matches--primary(#B2D3FF), mirroring light mode where--infoalready equals--primarySelected / active states:
twMerge(the item composestoggleVariants), so standaloneTogglekeeps its subtlebg-accenton-state.color-mix(--card, white 20%)so the selected tab clearly separates from the track (light mode keeps stockbg-card).Button hovers (stock hovers were near-invisible in dark):
accentin dark (drop the faintdark:hover:bg-accent/50anddark:hover:bg-input/50); outline now matches ghost.--foregroundwas a near-no-op for the light primary in dark — hence each button mixes toward the color chosen to contrast with its own fill.)Screenshots (dark mode — before = stock 0.7.0, after = this PR)
Captured from the SW-2041 visual-audit app, which consumes the built package. The button-hover shots show the row with the target button hovered.
Testing
yarn lint(zero-warning) +yarn typecheck+yarn test:all(148 files / 1365 tests) ✅postbuildTailwind compile:.bg-primary/.bg-secondaryremainvar(--*)(theme-responsive), the.dark {}block carries the new tokens, and thecolor-mix(...)hover/active utilities emit correctly.bg-accenton-state in favor ofbg-primaryfor ToggleGroup items only.@theme inlinecolors, so primary/secondary/accent don't reflect the theme toggle there — the shipped build (and the audit app screenshots above) render correctly.Notes
🤖 Generated with Claude Code