Skip to content

fix(vpn): validate WireGuard keys before persistence (#541)#4

Open
thedancingdeveloper wants to merge 1 commit into
mainfrom
fix/541-wireguard-key-validation
Open

fix(vpn): validate WireGuard keys before persistence (#541)#4
thedancingdeveloper wants to merge 1 commit into
mainfrom
fix/541-wireguard-key-validation

Conversation

@thedancingdeveloper

Copy link
Copy Markdown
Owner

Summary

  • require canonical 32-byte WireGuard key material
  • reject malformed peer public and preshared keys before database writes
  • verify a tunnel public key matches its private key before persistence
  • add common and core regression coverage for invalid keys and mismatched pairs

Closes ZerosAndOnesLLC#541

Validation

  • cargo fmt --all -- --check
  • cargo clippy -p aifw-common -p aifw-core --all-targets -- -D warnings
  • cargo test -p aifw-common -p aifw-core (367 unit tests plus integration tests passed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WireGuard fallback generates a public key unrelated to the private key

2 participants