soundwire: dmi-quirks: add a global ghost list#5826
Open
bardliao wants to merge 1 commit into
Open
Conversation
Not like other ghost devices, the 0x000000D010010500 ADR doesn't belong to any codec. We should disable it in all devices. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a global SoundWire _ADR “ghost” remap so that a known-bogus ACPI address (0x000000D010010500) is disabled (remapped to 0) on all systems, independent of DMI-specific quirk tables.
Changes:
- Introduces a
global_ghost_adrremap table containing the ghost _ADR → 0 mapping. - Extends
sdw_dmi_override_adr()to apply the global ghost remap in addition to existing DMI-based remaps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
188
to
+193
| for (map = dmi_id->driver_data; map->adr; map++) { | ||
| if (map->adr == addr) { | ||
| dev_dbg(bus->dev, "remapped _ADR 0x%llx as 0x%llx\n", | ||
| addr, map->remapped_adr); | ||
| addr = map->remapped_adr; | ||
| break; | ||
| goto out; |
Collaborator
Author
There was a problem hiding this comment.
It is on purpose. If we already remapped an addr, we should return that addr. Also, addr should not be 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not like other ghost devices, the 0x000000D010010500 ADR doesn't belong to any codec. We should disable it in all devices.