Skip to content

schedule: use k_thread_cpu_pin() for CPU affinity #10953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsarha wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

schedule: use k_thread_cpu_pin() for CPU affinity #10953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/schedule/zephyr_dma_domain.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,7 @@ static int zephyr_dma_domain_register(struct ll_schedule_domain *domain,
K_FOREVER);

#ifdef CONFIG_SCHED_CPU_MASK
k_thread_cpu_mask_clear(thread);
k_thread_cpu_mask_enable(thread, core);
k_thread_cpu_pin(thread, core);
#endif
Comment on lines 464 to 466

@jsarha jsarha Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

k_thread_name_set(thread, thread_name);

Expand Down
6 changes: 2 additions & 4 deletions src/schedule/zephyr_domain.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,7 @@ static int zephyr_domain_register(struct ll_schedule_domain *domain,
NULL, CONFIG_LL_THREAD_PRIORITY, 0, K_FOREVER);

#ifdef CONFIG_SCHED_CPU_MASK
k_thread_cpu_mask_clear(thread);
k_thread_cpu_mask_enable(thread, core);
k_thread_cpu_pin(thread, core);
#endif
Comment on lines 220 to 222

@jsarha jsarha Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Comment on lines 220 to 222

@jsarha jsarha Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

k_thread_name_set(thread, thread_name);

Expand Down Expand Up @@ -337,8 +336,7 @@ static int zephyr_domain_thread_init(struct ll_schedule_domain *domain,
K_USER, K_FOREVER);

#ifdef CONFIG_SCHED_CPU_MASK
k_thread_cpu_mask_clear(thread);
k_thread_cpu_mask_enable(thread, core);
k_thread_cpu_pin(thread, core);
#endif
k_thread_name_set(thread, thread_name);

Expand Down
3 changes: 1 addition & 2 deletions zephyr/edf_schedule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ int scheduler_init_edf(void)

k_thread_heap_assign(thread, sof_sys_heap_get());
#ifdef CONFIG_SCHED_CPU_MASK
k_thread_cpu_mask_clear(thread);
k_thread_cpu_mask_enable(thread, PLATFORM_PRIMARY_CORE_ID);
k_thread_cpu_pin(thread, PLATFORM_PRIMARY_CORE_ID);
#endif
Comment on lines 116 to 118

@jsarha jsarha Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is annother fix, not the one this PR is fixing. And the only reason that may cause k_thread_cpu_pin() to fail is that thread is already running, which is obviously not the case here, so check is quite futile.

k_thread_name_set(thread, "edf_workq");

Expand Down
Loading