Fix phantom devDependencies for pnpm compatibility - #1769
Open
MooseTheRebel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added
@eslint/jsandtypescript-eslintas explicitdevDependenciesinfrontend/package.json, pinned to9.39.5and8.65.0to match the already-declaredeslintand@typescript-eslint/eslint-plugin/parserversions.Regenerated
frontend/package-lock.jsonvianpm install, which also dropped a stray duplicate transitivetypescript-eslint@8.61.1entry now that the top-level dependency resolves and dedupes correctly.Why?
The
frontend/eslint.config.jsconfiguration imports@eslint/jsandtypescript-eslintdirectly, but neither was declared inpackage.json. Under npm's flatnode_modules, these resolved anyway because both are hoisted transitive dependencies.This breaks outright under
pnpm's strict linking (pnpm run lintfails withERR_MODULE_NOT_FOUND), which matters as pnpm is adopted (#1746).It's also a correctness issue independent of that migration, since it only works today by accident of npm's hoisting behavior.
Limitations and Notes
This declares the dependencies explicitly, so that if the maintainers prefer they can merge this without the full
pnpmmigration.Applicable Issues
Closes #1753
Screenshots
N/A — no UI changes.