DEMO - DO NOT MERGE: prove the additivity gate goes red (#1770) - #1771
Closed
aatchison wants to merge 1 commit into
Closed
DEMO - DO NOT MERGE: prove the additivity gate goes red (#1770)#1771aatchison wants to merge 1 commit into
aatchison wants to merge 1 commit into
Conversation
Throwaway non-additive migration, to show the migration-additivity CI job firing. #1770 adds no migrations, so its own run reports 'nothing to check' and never exercises the checker invocation path. Covers three cases: 1. op.drop_column reached only through a helper (call-graph following) 2. add_column(nullable=False) with no server_default 3. destructive raw DDL via op.get_bind().execute() The destructive downgrade() must NOT be flagged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Purpose served — gate went red as intended. Evidence linked on #1770. Deleting the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway. Will be closed and the branch deleted as soon as CI reports.
#1770 adds no migrations, so its own
migration-additivityrun says "nothing to check" and never exercises the checker invocation path. This branch adds one deliberately non-additive migration so the job actually fires.Expected:
migration-additivityred with three findings, and the destructivedowngrade()not flagged.Evidence for #1770.