Use cidr_block for stage's peering route - #243
Open
Sancus wants to merge 1 commit into
Open
Conversation
tb_pulumi 21ffa599 folds additional_routes into the route table's inline routes rather than creating standalone aws.ec2.Route resources, and the inline form takes cidr_block. Stage still used destination_cidr_block, so the program failed with a TypeError before reaching any other resource. Prod was already updated.
ryanjjung
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
additional_routesentries are folded into the route table's inline routes, which takecidr_block. Stage useddestination_cidr_block, so the program raisedTypeError: Route._internal_init() got an unexpected keyword argumentand built nothing. Prod was already correct.Already applied to the stage stack.