fix(codex): expose HAPI threads to Codex Desktop#1022
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings
No findings.
Summary
Review mode: initial
No issues found in the added/modified lines. Residual risk: I did not run the test suite in this review context; the normal first-turn payload is covered, while the goal-first path is exercised but does not add a dedicated threadSource assertion.
Testing
Not run (automation/security review context).
HAPI Bot
There was a problem hiding this comment.
Findings
No findings.
Summary
Review mode: follow-up after new commits
No issues found in the added/modified lines. Residual risk: I did not run tests in this review context; I reviewed the current full diff plus the prior bot review and compare diff. The PR adds focused launcher assertions for normal first-turn creation, goal-first creation, and resume staying unchanged.
Testing
Not run (automation/security review context).
HAPI Bot
1 participant
Fixes #1019
Summary
threadSource: "user"thread/startpayloadRoot cause
HAPI persisted valid Codex threads with the correct
cwdand Git metadata, but omitted Codex app-server's supportedthreadSourcefield. Those threads were consequently stored withthreadSource=nullinstead of the native top-level user classification expected for user-visible conversations.Verification
expected undefined to be "user"bun run typecheck:clicodexRemoteLaunchersuite: 54/54 passedthreadSource: "user", correctcwd, andsource: "vscode"The full CLI run passed 1129 tests. Four unrelated runner integration assertions failed locally in the existing parallel spawn/stop stress flow; the changed Codex suite and all non-runner packages passed.