Skip to content

fix(test): use a real snapshot version in presign integration tests #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
designcode merged 1 commit into from
Jun 22, 2026
Merged

fix(test): use a real snapshot version in presign integration tests #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions test/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,9 +1270,17 @@ describe.skipIf(skipTests)('CLI Integration Tests', () => {

describe('presign command', () => {
const accessKey = process.env.TIGRIS_STORAGE_ACCESS_KEY_ID!;
let snapshotVersion: string;

beforeAll(() => {
runCli(`touch ${testBucket}/presign-test.txt`);
// Take a real snapshot AFTER creating the object so the snapshot
// version post-dates the object. The SDK resolves --snapshot-version
// by finding an object version <= the snapshot version, so a hardcoded
// timestamp can never match a freshly-created object.
runCli(`snapshots take ${testBucket}`);
const list = runCli(`snapshots list ${testBucket} --format json`);
snapshotVersion = JSON.parse(list.stdout.trim()).items[0].version;
});

afterAll(() => {
Expand Down Expand Up @@ -1338,23 +1346,23 @@ describe.skipIf(skipTests)('CLI Integration Tests', () => {

it('should generate presigned GET URL with --snapshot-version', () => {
const result = runCli(
`presign ${testBucket}/presign-test.txt --snapshot-version 1765889000501544464 --access-key ${accessKey}`
`presign ${testBucket}/presign-test.txt --snapshot-version ${snapshotVersion} --access-key ${accessKey}`
);
expect(result.exitCode).toBe(0);
expect(result.stdout.trim()).toMatch(/^https:\/\//);
});

it('should accept the --snapshot alias for GET', () => {
const result = runCli(
`presign ${testBucket}/presign-test.txt --snapshot 1765889000501544464 --access-key ${accessKey}`
`presign ${testBucket}/presign-test.txt --snapshot ${snapshotVersion} --access-key ${accessKey}`
);
expect(result.exitCode).toBe(0);
expect(result.stdout.trim()).toMatch(/^https:\/\//);
});

it('should reject --snapshot-version with --method put', () => {
const result = runCli(
`presign ${testBucket}/presign-test.txt --method put --snapshot-version 1765889000501544464 --access-key ${accessKey}`
`presign ${testBucket}/presign-test.txt --method put --snapshot-version ${snapshotVersion} --access-key ${accessKey}`
);
expect(result.exitCode).toBe(1);
expect(result.stderr).toContain(
Expand Down