refactor(main): remove git protocol support#4
Merged
Conversation
As this is still used by the test logic, I've moved it to the _test.go files. I don't expect to need this in production as the plaintext git protocol is rather insecure. Signed-off-by: Xe Iaso <xe@tigrisdata.com>
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unauthenticated
git://(plaintext) protocol support from the production daemon. The plaintext git protocol is insecure and not expected to be needed in production.The git protocol handling is still exercised by the test suite, so it has been moved into the
_test.gofiles rather than deleted outright.Changes
cmd/objgitd/main.gogit_protocol.gointogit_protocol_test.gofor continued test coverageexample_hook_test.goandhooks_test.goaccordinglyTest plan
go build ./...go test ./...