Debounce transient Kubernetes cluster-health failures#6782
Open
mterwill wants to merge 1 commit into
Open
Conversation
mterwill
force-pushed
the
codex/verbose-health-checks
branch
from
June 17, 2026 22:12
c1822d0 to
0d475ed
Compare
Contributor
|
this pr is marked as draft -- is this something you're still working on? |
mterwill
force-pushed
the
codex/verbose-health-checks
branch
3 times, most recently
from
July 24, 2026 14:24
577bbc1 to
ae720fa
Compare
Signed-off-by: Matt Terwilliger <matt.terwilliger@reddit.com>
mterwill
force-pushed
the
codex/verbose-health-checks
branch
from
July 24, 2026 14:43
ae720fa to
c9e4602
Compare
mterwill
marked this pull request as ready for review
July 24, 2026 14:53
Contributor
Author
|
Thanks @nicks! The original branch was meant to add observability into a failure we were seeing internally. I’ve investigated further and reworked it around what I believe is the underlying issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6742 changed
tilt ciso that any cluster error immediately fails the CI session. The cluster error it relies on, however, is produced by a single health-check poll and cleared by the next successful poll.Kubernetes evaluates health over a series of probes rather than treating one failed check as terminal. Its probe model uses a
failureThresholdand only considers the overall check failed after successive failures. Tilt should apply similar tolerance before turning a point-in-time health observation into an irreversible CI result.We see this most often on busy clusters with many concurrent CI jobs, where one brief control-plane interruption can cascade into failures across every active Tilt session.
This change requires health checks to fail continuously for one minute—five successive failed polls at the current 15-second interval—before reporting a cluster error. A successful check resets the timer immediately. Sustained failures still terminate CI, but one failed poll no longer amplifies a brief interruption into many permanent job failures.