Skip to content

Enable more pyright rules and fix some typing issues #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timrid merged 1 commit into from
Jul 20, 2026
Merged

Enable more pyright rules and fix some typing issues #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,6 @@ exclude = [
"libs",
]

# These warnings should be activated as "error" in the future, but for now we don't want to refactor the entire codebase right now.
# Valid values: "error", "warning", "information", "none"
reportInvalidTypeForm = "none"
reportMissingParameterType = "none"
reportUnknownArgumentType = "none"
reportUnknownParameterType = "none"
# These "unnecessary isinstance" checks often enhance readability or increase the future-proofness of the code,
# since you can then explicitly "raise" for other types. So we don't want to complain about them.
reportUnnecessaryIsInstance = "none"
Expand Down
4 changes: 2 additions & 2 deletions scripts/expr_mixin_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
]


def create_overload_bin(op, lhs=None, rhs=None):
def create_overload_bin(op: str, lhs: int | bool | float | None = None, rhs: int | bool | float | None = None):
if lhs is None and rhs is None:
print(" @t.overload")
print(f" def {op}(self, other: t.Any) -> BinExpr[t.Any]: ...")
Expand All @@ -68,7 +68,7 @@ def create_overload_bin(op, lhs=None, rhs=None):
except AttributeError:
pass

def create_overload_uni(op, obj=None):
def create_overload_uni(op: str, obj: int | bool | float | None = None):
if obj is None:
print(" @t.overload")
print(f" def {op}(self) -> UniExpr[t.Any]: ...")
Expand Down
Loading