add InteractionModelRevision to im_status_response and im_write_request#11
Merged
Merged
Conversation
Every Interaction Model action message must carry the InteractionModelRevision field (tag 0xFF). It is already written by im_invoke_request, im_read_request, im_subscribe_request_attr/event, im_timed_request and im_unsubscribe_all, but was missing on im_status_response and im_write_request. Strict IM publishers (e.g. matter.js / Matterbridge) reject messages without it with INVALID_ACTION (0x80). For a StatusResponse sent in reply to a subscription ReportData this tears the subscription down, so no ongoing reports flow; lenient devices accept it, which is why it went unnoticed.
jr42
force-pushed
the
im-revision-status-write
branch
from
f6d58c9 to
db9d311
Compare
jr42
force-pushed
the
im-revision-status-write
branch
from
db9d311 to
f6d58c9
Compare
Owner
|
it looks ok. thank you for sharing fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Interaction Model action message must carry the mandatory
InteractionModelRevisionfield (tag 0xFF). It is already written byim_invoke_request,im_read_request,im_subscribe_request_attr/event,im_timed_requestandim_unsubscribe_all, but was missing onim_status_responseandim_write_request.Strict IM publishers (e.g. matter.js / Matterbridge) reject messages without it with
INVALID_ACTION(0x80). For a StatusResponse sent in reply to a subscriptionReportDatathis tears the subscription down, so no ongoing reports flow; lenient devices accept it, which is why it went unnoticed.Adds a unit test pinning that both builders emit tag 0xFF.