feat(auth): allow pinning the webauth callback port#1
Closed
tomaskir wants to merge 1 commit into
Closed
Conversation
Browser login (--mode webauth) starts a local HTTP callback server on a
random port (8002-20002), so the port cannot be known ahead of time. That
breaks webauth inside containers, where Docker port publishing (-p) needs a
fixed port; the only workaround was --network=host, which is Linux-only and
inconsistent on Docker Desktop.
Add a --webauth-port flag and a matching PHASE_WEBAUTH_PORT env var to pin
the callback server to a caller-specified port. The resolved port is used
both for net.Listen and in the webauth payload's port field, so the Console
redirects back to the same fixed port:
phase auth --mode webauth --webauth-port 8002
docker run -p 8002:8002 ... phase auth --mode webauth --webauth-port 8002
Precedence is flag, then env var, then the existing random port. Omitting
both keeps today's behavior, so this is fully backward compatible. Port
resolution is extracted into a pure resolveWebAuthPort helper with unit
tests covering the flag/env/random and validation paths.
Closes phasehq#305
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing: opening against upstream phasehq/cli instead.