feat: resolve review comments with notes; rework read_feedback with claim-aware scoping#12
Open
brendanwhit wants to merge 2 commits into
Open
feat: resolve review comments with notes; rework read_feedback with claim-aware scoping#12brendanwhit wants to merge 2 commits into
brendanwhit wants to merge 2 commits into
Conversation
… read_feedback to read the comment store with claim-aware scoping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the loop on review comments: Claude can now mark comments resolved (with a note saying how each was addressed), and
read_feedbackreads the comment store directly instead of the submitted-output file.New MCP tool:
resolve_comments{id, note}pairs (ids come fromread_feedback), marks each comment resolved and records the resolution note.read_feedbackby default and collapse into a GitHub-style "Resolved (N)" section in the UI (diff lines and document blocks).read_feedbackreworkoutputPath.includeResolved(show resolved comments with their notes) anditem(filter to one tab).createdAt; feedback submitted before the current session claimed the review is split into a separate "Earlier pending comments" section so a fresh session can tell new feedback from a stale backlog. Comments persisted before timestamps existed are treated as backlog.UI
CommentRow).ResolvedSection, used in diff and document views)./projectscount matches).Tests
server/__tests__/read-feedback-scoping.test.tscovering createdAt stamping, backlog/fresh splitting, resolution clearing the backlog section, and item filtering.routes.test.tscount expectation updated for resolved comments being excluded.npm run lint,npm run format:check,npm run build,npm testall green (243 passed).Second commit is the
dist/sync.🤖 Generated with Claude Code