Skip to content

feat: resolve review comments with notes; rework read_feedback with claim-aware scoping#12

Open
brendanwhit wants to merge 2 commits into
tomplex:mainfrom
brendanwhit:resolve-comments
Open

feat: resolve review comments with notes; rework read_feedback with claim-aware scoping#12
brendanwhit wants to merge 2 commits into
tomplex:mainfrom
brendanwhit:resolve-comments

Conversation

@brendanwhit

Copy link
Copy Markdown
Contributor

What

Closes the loop on review comments: Claude can now mark comments resolved (with a note saying how each was addressed), and read_feedback reads the comment store directly instead of the submitted-output file.

New MCP tool: resolve_comments

  • Takes {id, note} pairs (ids come from read_feedback), marks each comment resolved and records the resolution note.
  • Resolved comments drop out of read_feedback by default and collapse into a GitHub-style "Resolved (N)" section in the UI (diff lines and document blocks).

read_feedback rework

  • Reads live comments from the store (grouped by file/document, sorted by line/block, each tagged with its id) instead of outputPath.
  • New optional params: includeResolved (show resolved comments with their notes) and item (filter to one tab).
  • Comments are stamped with createdAt; feedback submitted before the current session claimed the review is split into a separate "Earlier pending comments" section so a fresh session can tell new feedback from a stale backlog. Comments persisted before timestamps existed are treated as backlog.

UI

  • Resolution note rendered under resolved comments (CommentRow).
  • Resolved comments collapse behind a "Resolved (N)" toggle (ResolvedSection, used in diff and document views).
  • Pending badge and user-comment counts no longer include resolved comments (server /projects count matches).

Tests

  • New server/__tests__/read-feedback-scoping.test.ts covering createdAt stamping, backlog/fresh splitting, resolution clearing the backlog section, and item filtering.
  • routes.test.ts count expectation updated for resolved comments being excluded.
  • npm run lint, npm run format:check, npm run build, npm test all green (243 passed).

Second commit is the dist/ sync.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant