Notification and package#19
Merged
Merged
Conversation
…ions and screenshare failures to the frontend UI
…ality, and notification interaction handling and improve press-talk event
… registration with cross-platform mapping
native package still bugged
…dencies in package-lock.json
There was a problem hiding this comment.
Pull request overview
This PR expands the Electron desktop app with a notification system (custom iframe notifications + OS notifications), adds tray/minimize-to-tray behavior, introduces push-to-talk support via a global key hook, and swaps the custom native screenshare addon for the electron-native-screenshare package while reorganizing preload scripts.
Changes:
- Added
NotificationManager+ notification IPC/preload wiring for in-app and OS notifications. - Implemented tray mode and push-to-talk key handling via
uiohook-napi. - Replaced the in-repo native capture addon with
electron-native-screenshareand updated preload structure/build packaging.
Reviewed changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Windows.js | Enables devtools only in development and adjusts preload path; tightens update-check environment gating. |
| utils.js | Updates BrowserWindow preload paths for screenshare and OSS windows. |
| preloads/screenshare.js | Adds dedicated screenshare preload exposing stream APIs via IPC. |
| preloads/oss.js | Adds dedicated OSS preload exposing OSS/external-link IPC APIs. |
| preloads/notification.js | Adds notification window preload for click/close/event IPC wiring. |
| preloads/main.js | Renames/extends main preload APIs, adds PTT + notification response listeners, and intercepts getDisplayMedia for native audio routing. |
| preloads/loading.js | Adds loading window preload with close IPC. |
| NotificationManager.js | Introduces queued multi-notification window manager + OS notification helper. |
| main.js | Adds tray mode, global error forwarding, PTT via uiohook-napi, notification IPC, and switches capture module to electron-native-screenshare. |
| linuxscript.js | Updates desktop protocol entry and adds --disable-dev-shm-usage + icon handling; disables older sandbox/shm helpers. |
| package.json | Bumps version, adds new native deps, modifies start scripts, and updates build file inclusion for preloads and native module. |
| package-lock.json | Updates dependency tree for new native deps and removes old local native addon link; version fields changed. |
| electron-builder.config.js | Updates packaged files/native unpacking and excludes uiohook-napi from this config’s build output. |
| native/topluyo-capture/src/wasapi_capture.h | Removes legacy in-repo WASAPI capture header. |
| native/topluyo-capture/src/wasapi_capture.cpp | Removes legacy in-repo WASAPI capture implementation. |
| native/topluyo-capture/src/addon.cpp | Removes legacy N-API addon entrypoint. |
| native/topluyo-capture/package.json | Removes legacy native addon package metadata. |
| native/topluyo-capture/package-lock.json | Removes legacy native addon lockfile. |
| native/topluyo-capture/index.js | Removes legacy JS wrapper for the native addon. |
| native/topluyo-capture/binding.gyp | Removes legacy node-gyp build config. |
| native/topluyo-capture/.gitignore | Removes legacy ignore rules. |
| native/.gitignore | Removes legacy ignore rules. |
Files not reviewed (1)
- native/topluyo-capture/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+8
to
+11
| const os = require("os"); | ||
| const { uIOhook, UiohookKey } = require('uiohook-napi'); | ||
| const notificationManager = require("./NotificationManager"); | ||
| let currentPttKey = 'G'; // default |
Comment on lines
6
to
9
| "scripts": { | ||
| "start": "NODE_ENV=production electron .", | ||
| "dev": "set NODE_ENV=development&& electron .", | ||
| "start": "ELECTRON_DISABLE_SANDBOX=1 NODE_ENV=production electron . --disable-dev-shm-usage --no-sandbox", | ||
| "dev": "ELECTRON_DISABLE_SANDBOX=1 NODE_ENV=development electron . --disable-dev-shm-usage --no-sandbox", | ||
| "start:win": "set NODE_ENV=production&& electron .", |
Comment on lines
+100
to
+106
| hasShadow: false, | ||
| show: false, // Don't show until ready to slide in | ||
| webPreferences: { | ||
| nodeIntegration: true, | ||
| contextIsolation: false, | ||
| preload: path.join(__dirname, 'preloads', 'notification.js') | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added notification system, impove native screen share package, Added tray mode and native key press event package for push to talk