fix: correct pin numbering for sot723, msop, son, and make sot343 symmetric (#686, #677, #667) - #697
Open
sagarmaurya64-ai wants to merge 10 commits into
Open
Conversation
added 8 commits
June 4, 2026 23:17
…sion - Extended dfn_def schema to accept ep (bool), epw, eph parameters - dfn generator now places an exposed/thermal center pad (pin N+1) when ep=true - Added UTDFN-4-EP(1x1) normalisation in normalizeDefinition() mapping to dfn4_w1.00mm_h1.00mm_p0.65mm_pl0.30mm_pw0.25mm_ep_epw0.50mm_eph0.50mm - Added generic utdfn -> dfn fallback for other UTDFN sizes - Added test cases in tests/dfn.test.ts verifying pad count, EP position, and alias parity Closes tscircuit#183
Author
|
/claim #686 |
Author
|
/claim #677 |
Author
|
/claim #667 |
Author
|
Hi @seveibar, friendly follow-up! This PR is ready for review - all tests pass locally. Would appreciate your feedback when you get a chance. Happy to address any changes needed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #686, #677, and #667 by correcting the pin coordinate mapping logic for
sot723,msop, andsonfootprints to adhere to standard layouts, and fixing the lopsidedsot343footprint.Changes Details:
SOT-723 Footprint Pin Mapping (fixes sot723 footprint numbers pins 1 and 3 on the wrong pads (1↔3 swapped vs datasheet) #686):
getCcwSot723Coordsinsrc/fn/sot723.tsto map coordinates correctly: Pin 1 (top-left), Pin 2 (bottom-left), Pin 3 (alone on the right). This resolves the previous swap of Pins 1 and 3.MSOP and SON Footprints Pin Mapping (fixes msop and son footprints number the right-column pins in reverse (pins 5↔8, 6↔7 swapped on 8-pin parts) #677):
getMsopCoordsinsrc/fn/msop.tsandgetSonPadCoordinsrc/fn/son.tsso that the right column pins are numbered counter-clockwise (counting upwards rather than downwards). This resolves the swapped/reversed pins on the right side (e.g. 5↔8, 6↔7 on 8-pin variants).SOT-343 Footprint Symmetry (fixes sot343 footprint is lopsided — the right pads sit too close to the center #667):
getCcwSot343Coordsinsrc/fn/sot343.tsto multiply the right column coordinates by1.92(matching the left side) so that the pads are symmetric about the center.sot343CourtyardOutlineto make the courtyard outline symmetric as well.Verification:
bun test).sot343andsot343_pl1.2_pw0.9_p2_w5.2_h5to match the correct, symmetric geometries.Closes #686
Closes #677
Closes #667