Add crystal4 footprinter - #707
Merged
Merged
Conversation
seveibar
marked this pull request as ready for review
July 13, 2026 22:41
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crystal4footprinter familyWhy
The imported X322512MSB4SI footprint in common#78 only matched an existing generic footprint at 0.939 copper IoU. A dedicated four-pad crystal generator represents its 2×2 land pattern directly.
Impact
crystal4_px2.2mm_py1.7mm_pw1.4mm_ph1.2mmmatches the target copper at 1.000 IoU while retaining the source pin positions.Validation
bun test tests/crystal.test.tsbun test— 434 pass, 0 failbun run buildgit diff --check