Increase packing iteration limit#174
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
force-pushed
the
agent/fix-large-partition-iteration-budget
branch
from
July 26, 2026 17:55
d178a77 to
91ee151
Compare
imrishabh18
changed the title
imrishabh18
marked this pull request as ready for review
July 26, 2026 18:04
seveibar
reviewed
Jul 27, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
have you tried just increasing the iteration count? Changing pack strategies has a lot of implications for maintainability because we have to identify the strategy being used
Member
Author
Cool, even that will work |
imrishabh18
force-pushed
the
agent/fix-large-partition-iteration-budget
branch
from
July 27, 2026 00:47
91ee151 to
c07adf1
Compare
imrishabh18
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PackSolver2Why
The WLED circuit creates a large 146-component partition. Its layout is valid, but
PackSolver2needs more than 100,000 iterations to finish and previously failed withPackSolver2 ran out of iterations.This PR keeps the existing packing strategy and simply gives the solver enough iterations to complete. The regression verifies that all 146 components are placed without overlaps.
Validation
bun test— 56 passed, 1 skippedbun run build