Skip to content

Lay out parallel series branches - #189

Merged
MustafaMulla29 merged 1 commit into
mainfrom
agent/fix-strong-parallel-led-branches
Jul 30, 2026
Merged

Lay out parallel series branches#189
MustafaMulla29 merged 1 commit into
mainfrom
agent/fix-strong-parallel-led-branches

Conversation

@MustafaMulla29

@MustafaMulla29 MustafaMulla29 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • detect even strong-connection series paths that leave and return to two pins on the same side of a main chip
  • add a dedicated ParallelSeriesBranchSolver inner-partition strategy that starts from the generic packed layout and folds matching paths into two aligned branches
  • preserve allowed component rotations and reject refinements that cannot maintain chipGap
  • add Core-captured BQ24074 repro coverage for both top-side and right-side chip pins

Root cause

The generic packer minimizes connection distance, but the affected topology has multiple compact foldings. It has no concept of the conventional U-shaped schematic arrangement, so one status LED branch could be placed in line with the other branch instead of forming two parallel columns or rows.

The new behavior is isolated from SingleInnerPartitionPackingSolver: PackInnerPartitionsSolver selects the specialized strategy only when the topology matches, and the solver retains the original packed placement if the refinement is unsafe.

Impact

Strongly connected series branches now align predictably with the side of the main chip without manual schX/schY coordinates. Top/bottom attachments become parallel columns, while left/right attachments become parallel rows.

Validation

  • bun test — 80 passed, 1 skipped
  • bun run build
  • bun run format:check
  • focused top-side and right-side BQ24074 repro tests and SVG snapshots

Before:
Screenshot 2026-07-30 at 9 19 27 PM

Screenshot 2026-07-30 at 9 19 41 PM

After:
Screenshot 2026-07-30 at 9 22 02 PM

Screenshot 2026-07-30 at 9 27 45 PM

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
matchpack Ready Ready Preview Jul 30, 2026 3:48pm

Request Review

@MustafaMulla29
MustafaMulla29 marked this pull request as ready for review July 30, 2026 15:48

@mohan-bee mohan-bee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg , will this handle 3 series branches ??

@MustafaMulla29

Copy link
Copy Markdown
Contributor Author

lg , will this handle 3 series branches ??

Yes

@MustafaMulla29
MustafaMulla29 merged commit 3332619 into main Jul 30, 2026
5 checks passed
@MustafaMulla29
MustafaMulla29 deleted the agent/fix-strong-parallel-led-branches branch July 30, 2026 16:24
@tscircuitbot

Copy link
Copy Markdown

Thank you for your contribution! 🎉

PR Rating: ⭐⭐⭐
Impact: Major

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants