Lay out parallel series branches - #189
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
marked this pull request as ready for review
July 30, 2026 15:48
seveibar
approved these changes
Jul 30, 2026
mohan-bee
approved these changes
Jul 30, 2026
mohan-bee
left a comment
Contributor
There was a problem hiding this comment.
lg , will this handle 3 series branches ??
Contributor
Author
Yes |
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParallelSeriesBranchSolverinner-partition strategy that starts from the generic packed layout and folds matching paths into two aligned brancheschipGapRoot cause
The generic packer minimizes connection distance, but the affected topology has multiple compact foldings. It has no concept of the conventional U-shaped schematic arrangement, so one status LED branch could be placed in line with the other branch instead of forming two parallel columns or rows.
The new behavior is isolated from
SingleInnerPartitionPackingSolver:PackInnerPartitionsSolverselects the specialized strategy only when the topology matches, and the solver retains the original packed placement if the refinement is unsafe.Impact
Strongly connected series branches now align predictably with the side of the main chip without manual
schX/schYcoordinates. Top/bottom attachments become parallel columns, while left/right attachments become parallel rows.Validation
bun test— 80 passed, 1 skippedbun run buildbun run format:checkBefore:

After:
