Index pin ownership before building chip partitions - #191
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mohan-bee
marked this pull request as ready for review
July 31, 2026 05:27
seveibar
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ChipPartitionsSolverpreviously resolved both endpoints of every strong connection by scanning every chip and its pin list. Building the chip adjacency graph therefore repeated global pin-owner scans and could approachO(strong connections × chips × pins per chip)before the connected-component traversal even began.The same pin-owner map was also reimplemented in several solver paths, and grounded-load layout performed another owner scan after discovery had already found the main chip.
Evidence
Local synthetic benchmark using a 2,000-chip chain with 3,998 two-way strong-connection entries:
b964a93before index95e3721with indexMethod: Bun 1.3.14, one warm-up followed by seven measured runs on the same machine. This is focused evidence for the removed lookup hotspot, not a universal end-to-end performance claim.