savepoint forget hook#2252
Merged
Merged
Conversation
sivukhin
approved these changes
Jul 1, 2026
sivukhin
left a comment
sivukhin
left a comment
Contributor
There was a problem hiding this comment.
If this is eps-effort - should we ask clanker to write simple tests which will check that savepoint methods will be called in some expected order for some statements?
| nNew = iSavepoint + (( op==SAVEPOINT_RELEASE ) ? 0 : 1); | ||
| for(ii=nNew; ii<pPager->nSavepoint; ii++){ | ||
| sqlite3BitvecDestroy(pPager->aSavepoint[ii].pInSavepoint); | ||
| if( pagerUseWal(pPager) |
Contributor
There was a problem hiding this comment.
Is it bit more safer to cal xSavepointForget before any destruction from SQLite? Just worry that if SQLite will add some sqlite3DataDestroy(pPager->aSavepoint[ii].aWalData) later here - we will screw up with ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.