Skip to content

chore: clear clippy lints for green CI#55

Merged
scarmuega merged 1 commit into
mainfrom
chore/fix-clippy
Jun 22, 2026
Merged

chore: clear clippy lints for green CI#55
scarmuega merged 1 commit into
mainfrom
chore/fix-clippy

Conversation

@scarmuega

Copy link
Copy Markdown
Member

cargo clippy -- -D warnings (the CI lint gate) was failing on pre-existing warnings, so main is currently red. This clears them — a preliminary step for the next cshell release.

Fixes (no behavior change):

  • drop unused imports (search, tx/common) and the never-constructed UTxORPCParameters struct (+ its orphaned serde import);
  • collapse inner ifs into match guards in the explorer key handlers — the catch-all arm is a no-op _ => {}, so behavior is identical;
  • redundant closure → method reference; drop a needless Ok(..?).

Verification

  • cargo clippy -- -D warnings clean (also --all-targets);
  • cargo test green (7).

Context: these fixes were authored alongside the invoke-arg test (#54) but landed on the branch just after #54 merged, so they need this separate PR to reach main.

🤖 Generated with Claude Code

`cargo clippy -- -D warnings` (the CI gate) was failing on pre-existing
warnings. Fixes:

- drop unused imports (search, tx/common) and the never-constructed
  `UTxORPCParameters` struct (+ its now-orphaned serde import)
- collapse inner `if`s into match guards in the explorer key handlers
  (the catch-all arm is a no-op `_ => {}`, so behavior is unchanged)
- redundant closure → method reference; drop a needless `Ok(..?)`

No behavior change. `cargo clippy -- -D warnings` and `cargo test` green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@scarmuega, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 2 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f89a437-2738-4810-ab7e-8360cd0c137d

📥 Commits

Reviewing files that changed from the base of the PR and between 2940081 and 1233092.

📒 Files selected for processing (5)
  • src/explorer/widgets/tabs/accounts.rs
  • src/explorer/widgets/tabs/transactions.rs
  • src/provider/create.rs
  • src/search/mod.rs
  • src/tx/common.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-clippy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@scarmuega scarmuega merged commit bdf6ba8 into main Jun 22, 2026
10 checks passed
@scarmuega scarmuega deleted the chore/fix-clippy branch June 22, 2026 20:09
@scarmuega scarmuega mentioned this pull request Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant