Pull request for changing block name and adding multilanguage header for payment details#10
Open
metropolisdrachen wants to merge 6 commits into
Open
Pull request for changing block name and adding multilanguage header for payment details#10metropolisdrachen wants to merge 6 commits into
metropolisdrachen wants to merge 6 commits into
Conversation
Changed the block name to ensure a consistent order for payment and order information in the Oxid shop. The default order is: Order information -> further information; in the Unzer module, the order is: Payment information -> Order information. Added a multilingual heading for payment information.
Added translation for payment details header
Added translation for header payment details
Copied original code from APEX theme payment_other.html.twig, as the unzer code doesn´t show the payment method long descritions
Added instructions for executing migration script to update database. Migration does not execute on module activation
Corrected encoding issues in German translation for Unzer payment methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have changed the block name from {% block checkout_thankyou_info %} to {% block checkout_thankyou_payment_info %} to keep an consistent order in oxid eshop and added an multilingual header for the payment details. Maybe interesting to merge. Modyfied payment_other.html.twig to original APEX code as payment long descritions were not show with unzerdev original code