Skip to content

Memberof plugin#5

Open
F1rst-Unicorn wants to merge 5 commits into
uubk:masterfrom
vs-eth:memberof-plugin
Open

Memberof plugin#5
F1rst-Unicorn wants to merge 5 commits into
uubk:masterfrom
vs-eth:memberof-plugin

Conversation

@F1rst-Unicorn

Copy link
Copy Markdown

Enable memberof plugin

@F1rst-Unicorn F1rst-Unicorn mentioned this pull request Mar 6, 2020

@uubk uubk left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, I only have two small nitpicks.

Comment thread defaults/main.yml
gid: 1000
initialPassword: "{{ auth_kerberos_ldap_password }}"

auth_ldap_user_objectclasses:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here that inetUser is added automatically when the memberOf overlay is enabled?

---

- name: Add inetUser to system users
set_fact:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing a when: auth_ldap_use_memberof_plugin here.

Fix missing condition to add the inetUser
Document added objectclass
@mxmo0rhuhn

Copy link
Copy Markdown

@uubk Ping :)

@lukasredev

Copy link
Copy Markdown

@F1rst-Unicorn can we get this merged? :)

@F1rst-Unicorn

Copy link
Copy Markdown
Author

@lukasreichart please note that I took action for each comment I received. So I think it can be merged

@uubk

uubk commented Jul 17, 2020

Copy link
Copy Markdown
Owner

@mxmo0rhuhn / @lukasreichart / @F1rst-Unicorn This one is on me - I have two LDAP related PRs open that I need to test, which is going to take about half a day and I didn't have the time yet. Trying to squeeze that it somewhen in July/August.

@lukasredev

Copy link
Copy Markdown

@uubk is there anything we still need to do, to get this merged?

@lukasredev

Copy link
Copy Markdown

@uubk any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants