Precreate default app#87
Open
mbaldessari wants to merge 1 commit into
Open
Conversation
So, finally, after our PR [1] landed into gitops-1.21 (argo 3.4.3) we still got a few InvalidSpecError on the spoke's argo here and there. After the initial surprise, it turns out that this race condition has the same error message but is not the one we addressed in the PR [1]. In fact without PR [1] you could add a delay to the argocd instance and/or precreate the default AppProject but nothing would help because the InformerCache was already populated and only a manual sync/argocd restart would fix things. With PR [1] now merged, precreating the default AppProject absolutely does fix things. I have added also a 5 seconds startup delay to ArgoCD for good measure (Note: while I could add some code in the initContainer that checks for the default appproject, I prefer just a super simple 5 seconds timeout) Tested this patch and got about ~40 successful deployments in a row. [1] www.github.com/argoproj/argo-cd/pull/27672
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, finally, after our PR [1] landed into gitops-1.21 (argo 3.4.3) we
still got a few InvalidSpecError on the spoke's argo here and there.
After the initial surprise, it turns out that this race condition has
the same error message but is not the one we addressed in the PR [1].
In fact without PR [1] you could add a delay to the argocd instance
and/or precreate the default AppProject but nothing would help because
the InformerCache was already populated and only a manual sync/argocd
restart would fix things.
With PR [1] now merged, precreating the default AppProject absolutely
does fix things. I have added also a 5 seconds startup delay to ArgoCD
for good measure (Note: while I could add some code in the initContainer
that checks for the default appproject, I prefer just a super simple 5
seconds timeout)
Tested this patch and got about ~40 successful deployments in a row.
[1] www.github.com/argoproj/argo-cd/pull/27672