fix: restore green CI (revert js-yaml to 4.x, pin prettier)#65
Merged
Conversation
origin/main was broken in two independent ways; CI only surfaced the first because format:check failed and cancelled the run. 1. js-yaml 5.2.0 (#62) is a full API rewrite that drops `Type`, `DEFAULT_SCHEMA`, and `Schema.extend()`, which src/yaml/import.ts uses for the Symfony `!php/const` / `!php/enum` tags. It broke typecheck and the yaml/php-enum/event suites, and `@types/js-yaml` was left at 4.x. Pin back to ^4.3.0 until a proper 5.x migration is done. 2. prettier `^3.8.3` floats to 3.9.4 on a fresh `npm ci`; 3.9 collapses a short union type onto one line where 3.8 kept the multiline form, so format:check failed in CI while passing on cached 3.8.x. Pin exact 3.9.4 and reformat src/engine/types.ts to match. All 246 tests pass; typecheck, lint, format:check, and build are green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainwas broken in two independent ways. CI only surfaced the first becauseformat:checkfailed and cancelled the run beforetypecheck/testcould run.js-yaml 5.2.0 (chore(deps): bump js-yaml from 4.2.0 to 5.2.0 #62) is a full API rewrite that removes
Type,DEFAULT_SCHEMA, andSchema.extend()— exactly whatsrc/yaml/import.tsuses for the Symfony!php/const/!php/enumcustom tags. It broketypecheckand the yaml/php-enum/event test suites, and@types/js-yamlwas left at 4.x, mismatching the 5.x runtime. Reverted to^4.3.0until a proper 5.x migration is done.prettier
^3.8.3floats to 3.9.4 on a freshnpm ci. Prettier 3.9 collapses a short union type onto one line where 3.8 kept the leading-|multiline form, soformat:checkfailed in CI while passing on cached 3.8.x installs. Pinned exact3.9.4so local and CI format identically, and reformattedsrc/engine/types.ts.Verification
Full pipeline green locally: lint · format:check · typecheck · 246 tests · build. (246 tests run now vs 184 previously — the 4 yaml-dependent suites had been erroring on import.)
Follow-up
A real migration to the js-yaml 5.x API (
defineScalarTag/Schema) should be tracked separately so dependabot doesn't silently re-break the build.🤖 Generated with Claude Code