sensor-monitor: use {{...}} reference syntax (avoid ${...} config-reader collision)#10
Merged
Merged
Conversation
The Viam config reader reserves ${...} for its own placeholder replacement and
rejects unknown placeholders before the module sees the config. Switch the
action command reference delimiter to {{...}} (mustache-style) to avoid the
collision; also trim whitespace inside references. Updates code, tests, and README.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Daniel Botros (danielbotros)
requested a review
from Nicolas Palpacuer (NickPPC)
Nicolas Palpacuer (NickPPC)
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches the action-command reference delimiter from
${...}to{{...}}(mustache-style).Why
The Viam config reader reserves
${...}for its own placeholder replacement and rejects unknown placeholders before the module ever sees the config. So a config like"ts": "${msg.ts}"fails at load with:{{...}}doesn't collide with anything the config reader processes, so action references load and resolve cleanly.Changes
refExact/refAnynow match{{...}}; references are whitespace-trimmed.resolveValueerror messages, tests, and the README (with a note explaining the delimiter choice).Follow-up to #9 (the action model), which used
${...}.🤖 Generated with Claude Code