🐛 Preserve screenshot capture geometry#325
Closed
Robdel12 wants to merge 1 commit into
Closed
Conversation
Keep harness-supplied coordinate facts in the cloud payload so the API can build reliable screenshot identities and region evidence without guessing.
Contributor
Author
|
This browser-capture contract is superseded by the bitmap-native design. Vizzly must accept raw screenshots from any platform without requiring browser-specific capture metadata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The screenshot client accepted harness capture facts such as the coordinate mode, device scale factor, and element selector, but normalization dropped them before the cloud request. That left the API without the source facts it needs to build reliable screenshot identities or translate Honeydiff regions into CSS coordinates.
What changed
captureMode,deviceScaleFactor, andselectoras reserved screenshot options in the cloud properties payload.propertiesshape with the existing reserved-option warning behavior.Confidence
The full CLI suite passes (2,321 passing, 5 skipped), the production build completes, and the published type definitions pass their contract checks.