fix(scan): flag openapi operations reachable without authentication#175
Open
TBX3D wants to merge 1 commit into
Open
fix(scan): flag openapi operations reachable without authentication#175TBX3D wants to merge 1 commit into
TBX3D wants to merge 1 commit into
Conversation
specToResult computed an operation's auth status with len(op.Security) == 0,
which a value slice cannot tell apart from an absent block: an operation that
overrides the global requirement with an empty array (security: []) or an
empty requirement object (security: [{}]) decoded the same as one that simply
inherits the global default, so those deliberately-public endpoints were
reported as authenticated. decode the operation security into a pointer to
keep absent distinct from explicit-empty, and treat both empty forms as
anonymous-reachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specToResult computed an operation's auth status with len(op.Security) == 0, which a value slice cannot tell apart from an absent block: an operation that overrides the global requirement with an empty array (security: []) or an empty requirement object (security: [{}]) decoded the same as one that simply inherits the global default, so those deliberately-public endpoints were reported as authenticated. decode the operation security into a pointer to keep absent distinct from explicit-empty, and treat both empty forms as anonymous-reachable.