Optimization: Share opposite-polarity literals in clause code trees#880
Open
Synrom wants to merge 6 commits into
Open
Optimization: Share opposite-polarity literals in clause code trees#880Synrom wants to merge 6 commits into
Synrom wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes clause code tree subsumption resolution by sharing literal information across polarities. Instead of storing separate positive and negative
LitInfoentries for each literal, matching records whether a result came from the opposite polarity and handles that during matcher execution.The implementation preserves subsumption priority over subsumption resolution by keeping non-opposite matches first in
ILStructand makingClauseMatcher::matchGlobalVarstry non-opposite matches before falling back to opposite-polarity matches.This optimization is currently not compatible with
CHECK_GROUND_TERM=1.