Replace deprecated WANDB_LOG_MODEL=true with end in HF optimize notebook#631
Open
johndmulhausen wants to merge 1 commit into
Open
Replace deprecated WANDB_LOG_MODEL=true with end in HF optimize notebook#631johndmulhausen wants to merge 1 commit into
johndmulhausen wants to merge 1 commit into
Conversation
Modern transformers raises ValueError: 'true' is not a valid WandbLogModel. Use 'end' to log the final model as an artifact, and mention 'checkpoint' as the alternative for per-checkpoint logging. Also fixes the 'varilable' typo on the same line. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Hugging Face optimization Colab notebook to use the current transformers-supported WANDB_LOG_MODEL values, preventing runtime failure caused by the deprecated true setting.
Changes:
- Replaced
%env WANDB_LOG_MODEL=truewith%env WANDB_LOG_MODEL=endto matchWandbLogModelenum expectations. - Updated the related markdown tip to recommend
end(and mentioncheckpoint), and fixed a spelling typo (“varilable” → “variable”).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johndmulhausen
marked this pull request as ready for review
July 21, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Optimize_Hugging_Face_models_with_Weights_&_Biases.ipynbsets%env WANDB_LOG_MODEL=true. Moderntransformersno longer acceptstrue— theWandbLogModelenum only acceptsend,checkpoint, orfalse, so running the notebook crashes with:(with a DeprecationWarning telling users to use
'end'or'checkpoint'instead).Fix
%env WANDB_LOG_MODEL=true→%env WANDB_LOG_MODEL=endWANDB_LOG_MODELtoend(mentioningcheckpointas the alternative for per-checkpoint logging), and fixed the "varilable" typo on the same lineNo other changes; the notebook JSON is otherwise untouched.
Verification
Against the current
transformersrelease in a fresh venv:Notebook validated with
nbformat.validate(...)(nbformat 4) — passes.grepconfirms no remainingWANDB_LOG_MODEL=truein this notebook.Fixes #572
Fixes #598
🤖 Generated with Claude Code